Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update flip to split out parameter pragma from nested structure #236

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

update flip to split out parameter pragma from nested structure #236

wants to merge 1 commit into from

Conversation

bthaile
Copy link
Contributor

@bthaile bthaile commented Jan 4, 2024 •
edited
Loading

update flip to split out parameter pragma from nested structure

Nested pragma structure can be parsed but not executed at runtime. To get around this issue the parameters get their own pragmas.

New way:

#interaction(
	version: "1.1.0",
	title: "Transfer Flow",
	description: "Transfer Flow to account",
	language: "en-US",	
)

#interaction-param-amount(
        title: "Amount", 
        description: "Amount of Flow to transfer",
	language: "en-US",
)	

#interaction-param-to(
	title: "Reciever", 
	description: "Destination address to receive Flow Tokens",
	language: "en-US",
)

Old way:

#interaction(
    version: "1.1.0",
    title: "Transfer Flow",
    description: "Transfer Flow to account",
    language: "en-US",
    parameters: [
        Parameter(
            name: "amount", 
            title: "Amount", 
            description: "Amount of Flow to transfer"
        ),
        Parameter(
            name: "to", 
            title: "Reciever", 
            description: "Destination address to receive Flow Tokens"
        )
    ],
)

@bthaile bthaile marked this pull request as draft January 4, 2024 22:00
@bthaile
Copy link
Contributor Author

bthaile commented Jan 4, 2024

Putting PR in draft, pragmas are being update to allow for nested structures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bthaile bthaile

Labels
flip: application Application FLIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bthaile @franklywatson